Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

E mage map docs #988

Merged
merged 8 commits into from
Aug 4, 2023
Merged

E mage map docs #988

merged 8 commits into from
Aug 4, 2023

Conversation

imilinovic
Copy link
Contributor

Description

Please briefly explain the changes you made here.

We added a page in the mage docs for new map query module and its functions.

Pull request type

Please delete options that are not relevant and check the ones that are.

  • New documentation page

PR this doc page is related to:
Closes (link to issue):
PR282

Checklist:

  • I checked all content with Grammarly
  • I performed a self-review of my code
  • I made corresponding changes to the rest of the documentation
  • The build passes locally
  • My changes generate no new warnings or errors

ind1xa and others added 4 commits August 1, 2023 13:49
@imilinovic imilinovic added the status: draft PR is in draft phase label Aug 2, 2023
@imilinovic imilinovic marked this pull request as ready for review August 2, 2023 12:12
@imilinovic imilinovic added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Aug 2, 2023

```cypher
CALL map.remove_key({c: "b", d: "ba"}, "c") YIELD removed
RETURN removed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check all your queries, they need to end with a ;

@vpavicic
Copy link
Collaborator

vpavicic commented Aug 3, 2023

Three notes for the future and how to make a tech writer and users (other devs) happy :)

  1. Just like every programming language, any natural language also has rules. Although our brain is a powerful compiler to understand it even when we break those rules, we should still try to comply with those rules. I noticed you often don't use commas, or periods at the end of sentences.

  2. Look at 1 and don't forget to end your Cypher queries with a ;

  3. When you are working on something as a team, the final product needs to look like it was created by a single entity, so you need to discuss and agree about formating for example Cypher queries - are they all in one line, or is each clause in its own row?

@vpavicic vpavicic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 3, 2023
Copy link
Collaborator

@vpavicic vpavicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if all cypher queries end with ;

@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 4, 2023
@imilinovic imilinovic requested a review from vpavicic August 4, 2023 07:17
@vpavicic vpavicic merged commit 8440630 into master Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
mage-release-1.9 status: ready PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants