Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return devices #58

Merged
merged 5 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions c_src/membrane_portaudio_plugin/pa_devices.c
Original file line number Diff line number Diff line change
@@ -1,31 +1,48 @@
#include "pa_devices.h"

UNIFEX_TERM list(UnifexEnv *env) {
UNIFEX_TERM list(UnifexEnv *env)
{
Pa_Initialize();
int numDevices = Pa_GetDeviceCount();
if (numDevices < 0) {
device devices[numDevices];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if numDevices is negative? :P Also, I'd allocate this on the heap just in case numDevices is big for some reason

char names[numDevices][255];
if (numDevices < 0)
{
printf("\nERROR: Pa_CountDevices returned 0x%x\n", numDevices);
return list_result(env);
} else if (numDevices == 0) {
return list_result_ok(env, devices, numDevices);
}
else if (numDevices == 0)
{
printf("\nNo audio devices found\n");
} else {
}
else
{
printf("\nAvailable audio devices:\n\n");
int default_input_id = Pa_GetDefaultInputDevice();
int default_output_id = Pa_GetDefaultOutputDevice();
for (int i = 0; i < numDevices; i++) {
for (int i = 0; i < numDevices; i++)
{
const PaDeviceInfo *device_info = Pa_GetDeviceInfo(i);
const char *default_str =
i == default_input_id
? " (default input)"
: i == default_output_id ? " (default output)" : "";
: i == default_output_id ? " (default output)"
: "";

printf("%s%s\r\n\tid: %d\r\n\tmax_input_channels: "
"%d\r\n\tmax_output_channels: %d\r\n\n",
device_info->name, default_str, i, device_info->maxInputChannels,
device_info->maxOutputChannels);
johns10 marked this conversation as resolved.
Show resolved Hide resolved

strncpy(names[i], device_info->name, 255);

devices[i].id = i;
devices[i].name = names[i];
devices[i].max_output_channels = device_info->maxOutputChannels;
devices[i].max_input_channels = device_info->maxInputChannels;
}
}

Pa_Terminate();
return list_result(env);
return list_result_ok(env, devices, numDevices);
}
11 changes: 10 additions & 1 deletion c_src/membrane_portaudio_plugin/pa_devices.spec.exs
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
module Membrane.PortAudio.Devices

spec list() :: :ok
type(
device :: %Device{
Copy link
Member

@mat-hek mat-hek Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
device :: %Device{
device :: %Membrane.PortAudio.Device{

Also, let's create a corresponding struct in a Membrane.PortAudio.Device module.

id: int,
name: string,
max_input_channels: int,
max_output_channels: int
}
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
max_output_channels: int
}
)
max_output_channels: int,
default_device: default_device
}
)
type(default_device :: false | :input | :output)

Then you can use that like device.device_default = DEVICE_DEFAULT_INPUT; in C

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added is_default, will move to this instead.

spec list() :: {:ok :: label, devices :: [device]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spec list() :: {:ok :: label, devices :: [device]}
spec list() :: (devices :: [device])