725 portaudio rename endpoint_id to device_id #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
reviewed
Mar 8, 2024
README.md
Outdated
| @@ -11,7 +11,7 @@ The plugin that captures and plays sound using the multiplatform PortAudio libra | |||
| Add the following line to your `deps` in `mix.exs`. Run `mix deps.get`. | |||
|
|
|||
| ```elixir | |||
| {:membrane_portaudio_plugin, "~> 0.18.4"} | |||
| {:membrane_portaudio_plugin, "~> 0.18.5"} | |||
There was a problem hiding this comment.
since this one changes API, we need to release v0.19.0
mat-hek
requested changes
Mar 11, 2024
| def_options endpoint_id: [ | ||
| def_options device_id: [ |
There was a problem hiding this comment.
I'd leave the old option too, but document it as deprecated and warn in handle_init
mat-hek
reviewed
Mar 11, 2024
Co-authored-by: Mateusz Front <[email protected]>
Co-authored-by: Mateusz Front <[email protected]>
mat-hek
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.