skip persumed AUs that don't have any VCL NALus #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
reviewed
May 14, 2024
| state | ||
| | skip_until_keyframe: state.skip_until_keyframe and not has_seen_keyframe? | ||
| } | ||
| defp first_vcl_nalu(au, state) do |
There was a problem hiding this comment.
for the sake of consistency you can add a typespec
varsill
approved these changes
May 14, 2024
| defp skip_au?(au, keyframe?, state) do | ||
| has_seen_keyframe? = keyframe? and Enum.all?(au, &(&1.status == :valid)) | ||
| @spec forward_au?(AUSplitter.access_unit(), boolean(), state()) :: {boolean(), state()} | ||
| defp forward_au?(au, keyframe?, state) do |
There was a problem hiding this comment.
shouldn't the function that ends with ? return bool? :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.