Add h265 tests #55
Merged
Add h265 tests #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
reviewed
Jan 10, 2024
| @@ -28,7 +28,7 @@ defmodule Membrane.H264.StreamFormatTest do | |||
| } | |||
|
|
|||
| defp perform_test(filename, timeout) do | |||
| in_path = Path.expand("../fixtures/input-#{filename}.h264", __DIR__) | |||
| in_path = Path.expand("../../fixtures/h264/input-#{filename}.h264", __DIR__) | |||
There was a problem hiding this comment.
I think we can also change it in the following way since you have already done it in a few other places:
Suggested change
| in_path = Path.expand("../../fixtures/h264/input-#{filename}.h264", __DIR__) | |
| in_path = Path.expand("test/fixtures/h264/input-#{filename}.h264", __DIR__) |
test/support/common.ex
Outdated
| do_prepare_bytestream_buffers(binary) | ||
| end | ||
|
|
||
| def prepare_buffers(binary, mode, output_stream_structure, stable_reprefixing?) do |
There was a problem hiding this comment.
[NIT] I would think of explicitly calling that function prepare_h264_buffers rather than having prepare_buffers and prepare_h265_buffers
varsill
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.