This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Mv 286 tile switching #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostatni5
reviewed
Jun 16, 2023
| hasSpoken(mediaPlayerId) || isSpeaking ? "speaking" : "rest" | ||
| )(remoteTiles); | ||
| const newSpeakingTiles = (speaking ?? []).filter(({ mediaPlayerId }) => !hasSpoken(mediaPlayerId)); | ||
| newSpeakingTiles.map(({ mediaPlayerId }) => mediaPlayerId).forEach(addToHistory); |
There was a problem hiding this comment.
The date is refreshed only for new tiles so "old speaking" participants can be hidden.
bblaszkow06
suggested changes
Jun 19, 2023
| const getTimeLastSpoken = useCallback((tileId: string) => speakingHistory.get(tileId) ?? 0, [speakingHistory]); | ||
| const addToHistory = useCallback( | ||
| (tileId: string) => { | ||
| if (!hasSpoken(tileId)) setSpeakingHistory((oldHistory) => new Map(oldHistory).set(tileId, Date.now())); |
There was a problem hiding this comment.
What about the ones who have spoken before? Why you're not updating their "last spoken time"?
| }; | ||
|
|
||
| const { localTiles, remoteTiles, screenshareTiles } = groupBy(({ typeName }: MediaPlayerTileConfig) => | ||
| typeName === "local" ? "localTiles" : typeName === "remote" ? "remoteTiles" : "screenshareTiles" |
There was a problem hiding this comment.
IMO this would be more readable with switch
|
Please make sure to align this change with the agreed design: https://docs.google.com/document/d/1HBr-Qf6IgtYPYMAaw7ZF3RzlElASf15LtKl2eO7EX9I/edit?usp=sharing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds switching of the Last Recently Spoken person.
The desired state of the unpinned tiles is: