Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Pinecone integration #2395

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Add: Pinecone integration #2395

merged 5 commits into from
Mar 20, 2025

Conversation

parshvadaftari
Copy link
Contributor

Description

This PR includes the integration for Pinecone.

Fixes #2385

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Have added test script for the pinecone.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multimodal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 4:50am

Dev-Khant
Dev-Khant reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@Dev-Khant Dev-Khant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments, rest all looks good.

mem0/vector_stores/pinecone.py Outdated
environment: Optional[str] = None,
serverless_config: Optional[Dict[str, Any]] = None,
pod_config: Optional[Dict[str, Any]] = None,
hybrid_search: bool = False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't hardcode the values here instead take the default values from the config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated the file.

@parshvadaftari
Copy link
Contributor Author

@Dev-Khant The tests for test_azure_ai_search are failing here.

@Dev-Khant
Copy link
Member

Hey @parshvadaftari Thanks for the contribution!!

@Dev-Khant Dev-Khant merged commit e33008e into mem0ai:main Mar 20, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dev-Khant Dev-Khant Dev-Khant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinecone as Vector DB
2 participants
@parshvadaftari @Dev-Khant