Skip to content

test: Validate lowest version requirements #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Mar 25, 2025

Summary by Sourcery

Adds a new test session to validate the package's compatibility with the lowest supported versions of its dependencies, and configures CI to run this test.

Tests:

  • Adds a test session to validate the package's compatibility with the lowest supported versions of its dependencies.
  • Updates the test matrix in CI to include the new test session.
  • Updates the minimum version of dependencies in pyproject.toml

📚 Documentation preview 📚: https://meltano-sdk--2923.org.readthedocs.build/en/2923/

Copy link
Contributor

sourcery-ai bot commented Mar 25, 2025

Reviewer's Guide by Sourcery

This pull request adds a new Nox session to test the package with the lowest dependency versions, updates the minimum version requirements for some dependencies, and adds a new job to the GitHub Actions workflow to run the new Nox session. The new session uses uv to install the lowest possible versions of the dependencies and then runs pytest.

Sequence diagram for test-lowest session

sequenceDiagram
    participant Session
    participant uv
    participant pip
    participant compile
    participant pytest

    Session->>uv: install uv, sync, --frozen, --no-dev, --group=testing, --extra=...
    Session->>uv: install uv, pip, compile
    Session->>compile: pyproject.toml, --python=3.9, --all-extras, --universal, --resolution, lowest-direct, -o=...
    compile-->>Session: requirements.txt
    Session->>pip: install -r requirements.txt
    Session->>pytest: run pytest
Loading

Updated class diagram for dependencies

classDiagram
    class dependencies {
      -click~=8.0
      -fs>=2.4.16
      -fsspec>=2024.9.0
      -importlib-metadata>=6.5; python_version<"3.12"
      -importlib-resources>=5.12.0,!=6.2.0,!=6.3.0,!=6.3.1; python_version<"3.10"
      -inflection>=0.5.1
      -joblib>=1.3.0
      -lxml>=4.6.3
      -msgspec>=0.18.0
      -pandas>=1.5.3
      -pydantic>=2.0
      -python-dateutil>=2.8.1
      -requests>=2.25.1
      -setuptools>=65,<=70.3.0
      -simpleeval>=0.9.13,!=1.0.1
      -simplejson>=3.17.6
      -sqlalchemy>=2
      -typing-extensions>=4.5.0
    }

    class parquet {
      -pyarrow>=15
    }
Loading

File-Level Changes

Change Details Files
Introduces a new Nox session to test the package with the lowest dependency versions.
  • Adds a new Nox session named test-lowest that uses Python 3.9.
  • Installs the package and its dependencies using uv with the lowest possible versions.
  • Runs pytest to execute the tests.
noxfile.py
Updates the minimum version requirements for some dependencies in pyproject.toml.
  • Updates the minimum version of importlib-metadata to 6.5.
  • Updates the minimum version of setuptools to 65.
  • Updates the minimum version of sqlalchemy to 2.
  • Updates the minimum version of pyarrow to 15.
pyproject.toml
Adds a new job to the GitHub Actions workflow to run the test-lowest Nox session.
  • Adds a new entry to the include list in the test.yml workflow to run the test-lowest session on Python 3.9.
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (7105df8) to head (815c5aa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2923   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          63       63           
  Lines        5319     5319           
  Branches      683      683           
=======================================
  Hits         4869     4869           
  Misses        318      318           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Performance Report

Merging #2923 will not alter performance

Comparing edgarrmondragon/chore/validate-min-deps (815c5aa) with main (7105df8)

Summary

✅ 7 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/validate-min-deps branch from 77fec86 to 815c5aa Compare April 17, 2025 22:01
@edgarrmondragon edgarrmondragon self-assigned this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant