Skip to content

Update setup.py#223

Open
gonzariosm wants to merge 1 commit intomegadose:masterfrom
gonzariosm:fix/requests
Open

Update setup.py#223
gonzariosm wants to merge 1 commit intomegadose:masterfrom
gonzariosm:fix/requests

Conversation

@gonzariosm
Copy link

Minor fix: Add requests as a required dependency

Issue

Running holehe inside the Docker image throws a ModuleNotFoundError:

ModuleNotFoundError: No module named 'requests'

Full traceback:

Click to expand Traceback (most recent call last): File "/usr/local/bin/holehe", line 33, in Twitter : @palenath Github : https://github.com/megadose/holehe For BTC Donations : 1FHDM49QfZX6pJmhjLE5tB2K6CaTLMZpXZ sys.exit(load_entry_point('holehe==1.61', 'console_scripts', 'holehe')()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 233, in main trio.run(maincore) File "/usr/local/lib/python3.11/site-packages/trio-0.30.0-py3.11.egg/trio/_core/_run.py", line 2435, in run raise runner.main_task_outcome.error File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 206, in maincore modules = import_submodules("holehe.modules") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 46, in import_submodules results.update(import_submodules(full_name)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 44, in import_submodules results[full_name] = importlib.import_module(full_name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1204, in _gcd_import File "", line 1176, in _find_and_load File "", line 1147, in _find_and_load_unlocked File "", line 690, in _load_unlocked File "", line 940, in exec_module File "", line 241, in _call_with_frames_removed File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/modules/social_media/facebook.py", line 4, in import requests # Adjust if using a different HTTP library ^^^^^^^^^^^^^^^ ModuleNotFoundError: No module named 'requests'

Steps to reproduce

git clone https://github.com/megadose/holehe.git
cd holehe
docker build . -t my-holehe-image
docker run my-holehe-image holehe test@gmail.com

Solution

Add requests to the list of required dependencies so that the module can be properly imported during execution.

Added requests package as required
@gonzariosm
Copy link
Author

@megadose, can you take a look at this PR and let me know if you need any change, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant