Open
Conversation
Added requests package as required
Author
|
@megadose, can you take a look at this PR and let me know if you need any change, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fix: Add requests as a required dependency
Issue
Running
holeheinside the Docker image throws aModuleNotFoundError:Full traceback:
Click to expand
Traceback (most recent call last): File "/usr/local/bin/holehe", line 33, in Twitter : @palenath Github : https://github.com/megadose/holehe For BTC Donations : 1FHDM49QfZX6pJmhjLE5tB2K6CaTLMZpXZ sys.exit(load_entry_point('holehe==1.61', 'console_scripts', 'holehe')()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 233, in main trio.run(maincore) File "/usr/local/lib/python3.11/site-packages/trio-0.30.0-py3.11.egg/trio/_core/_run.py", line 2435, in run raise runner.main_task_outcome.error File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 206, in maincore modules = import_submodules("holehe.modules") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 46, in import_submodules results.update(import_submodules(full_name)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/core.py", line 44, in import_submodules results[full_name] = importlib.import_module(full_name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1204, in _gcd_import File "", line 1176, in _find_and_load File "", line 1147, in _find_and_load_unlocked File "", line 690, in _load_unlocked File "", line 940, in exec_module File "", line 241, in _call_with_frames_removed File "/usr/local/lib/python3.11/site-packages/holehe-1.61-py3.11.egg/holehe/modules/social_media/facebook.py", line 4, in import requests # Adjust if using a different HTTP library ^^^^^^^^^^^^^^^ ModuleNotFoundError: No module named 'requests'Steps to reproduce
Solution
Add requests to the list of required dependencies so that the module can be properly imported during execution.