Feature/performant old filmlist reader #150
Conversation
|
SonarCloud Quality Gate failed. |
TheSasch
left a comment
TheSasch
left a comment
There was a problem hiding this comment.
Didn't had the time to have a look at the unit tests. I will do it later.
src/main/java/de/mediathekview/mlib/filmlisten/reader/FilmlistOldFormatReader.java
Outdated
Show resolved
Hide resolved
src/main/java/de/mediathekview/mlib/filmlisten/reader/OldFilmlistToRawFilmlistReader.java
Outdated
Show resolved
Hide resolved
src/main/java/de/mediathekview/mlib/filmlisten/reader/OldFilmlistToRawFilmlistReader.java
Outdated
Show resolved
Hide resolved
| import static java.time.format.FormatStyle.MEDIUM; | ||
|
|
||
| @Mapper | ||
| public interface RawFilmToFilmMapper { |
There was a problem hiding this comment.
Ok, lets talk about the mapper :)
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> |
There was a problem hiding this comment.
wieso Spring Boot? wird doch in MLib gar nicht verwendet.
There was a problem hiding this comment.
Im spring Boot parent sind für viele Abhängigkeiten die Versionen aufeinander abgestimmt und getestet. Wenn wir den, wie hier von mir getan, nutzen müssen wir uns nicht um Kompatibilität einzelner Versionen zueinander kümmern. Zum updaten von dependencies können wir so auch "einfach" die Spring version erhöhen und müssen uns dann nur noch um die zusätzlichen Deps kümmern.
src/main/java/de/mediathekview/mlib/filmlisten/reader/OldFilmlistToRawFilmlistReader.java
Outdated
Show resolved
Hide resolved
| import java.io.IOException; | ||
|
|
||
| import static jakarta.ws.rs.core.HttpHeaders.CONTENT_LENGTH; | ||
| import static javax.ws.rs.core.HttpHeaders.CONTENT_LENGTH; |
There was a problem hiding this comment.
MServer verwendet die jakarta-Variante, keine Ahnung ob das im Zusammenspiel mit MLib problematisch werden könnte. Warum wieder zurück zur "alten" Variante?
There was a problem hiding this comment.
Dependency Version hat sich geändert und da sind die Pfade noch so
TheSasch
left a comment
TheSasch
left a comment
There was a problem hiding this comment.
I also wrote some findings to Discord.
|
|
||
| @Mapper | ||
| public interface RawFilmToFilmMapper { | ||
| Logger LOG = LogManager.getLogger(RawFilmToFilmMapper.class); |
There was a problem hiding this comment.
Use @slf4j when you already use Lombok instead of self definiton
| Film rawFilmToFilm(RawFilm rawFilm); | ||
|
|
||
| default List<GeoLocations> mapGeolocation(RawFilm rawFilm) { | ||
| return GeoLocations.find(rawFilm.getGeo()).map(List::of).orElse(new ArrayList<>()); |
There was a problem hiding this comment.
return GeoLocations.find(rawFilm.getGeo()).stream().collect(Collectors.toList());
|
|
||
| @AfterMapping | ||
| default void complexMappings(RawFilm rawFilm, @MappingTarget Film film) { | ||
| long groesse = mapSize(rawFilm); |
|
SonarCloud Quality Gate failed. |
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
In context of the Filmlistmerger I created a new, more performant, reader for the old Filmlist .