Skip to content

Conversation

@Omar8345
Copy link


name: pull request
about: submit changes to the project
title: "[pr] implement search history for search pipe"
labels: 'feature, ui, enhancements'
assignees: '@Omar8345'


description

This PR implements persistent search history for the search pipe. Users can now see previous searches in the sidebar, select a search to reload it, rename history items, and delete them. The changes include both UI updates and backend storage for maintaining history across sessions.

related issue: #1382

how to test

  1. Open the app and go to the search pipe.
  2. Perform a few searches and verify they appear in the sidebar history.
  3. Click a search in the history sidebar to open it.
  4. Rename a history item and check the new name.
  5. Delete a history item and ensure it is removed.
  6. Reload the app and confirm history persists.
search.history.-.search.pipe.mov

/claim #1382

* add persistent search history storage

* display previous searches in sidebar

* allow selecting, renaming, and deleting history items

* update lockb
@github-actions
Copy link
Contributor

🧪 testing bounty created!

a testing bounty has been created for this PR: view testing issue

testers will be awarded $20 each for providing quality test reports. please check the issue for testing requirements.

@Omar8345
Copy link
Author

Hi @louis030195, just a friendly nudge on this PR 🙏

No rush, but since it’s connected to a bounty I’d be grateful if you could take a look when you have time. Thanks!

@Omar8345
Copy link
Author

@louis030195 please take this seriously. 3 weeks?

@Excellencedev
Copy link

@louis030195 please take this seriously. 3 weeks?

@Omar8345 It is something they do in their free time. Calm down and stop spamming or you will likely get banned

@Omar8345
Copy link
Author

@louis030195 please take this seriously. 3 weeks?

@Omar8345 It is something they do in their free time. Calm down and stop spamming or you will likely get banned

thanks for your advice

@Omar8345
Copy link
Author

Omar8345 commented Nov 8, 2025

@louis030195 mind checking this please??

@Excellencedev
Copy link

@Omar8345 close this pr and open a new one if u want someone to review it
the maintainers can't see it like this
also you can join their discord and request review
if they don't have discord, check other social media

Copy link

@Excellencedev Excellencedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many unnecessary and wrong changes. refactor this pr

Copy link

@Excellencedev Excellencedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has major merge artifacts and invalid code.

page.tsx: duplicated JSX → app won’t compile. Keep single

tree; remove duplicate Alert & aiDisabled lines.

search-chat.tsx: repeated imports + states; merge conflict remnants — keep one clean version only.

use-search-history.tsx: completely broken; two storage keys, async/sync mix, missing braces. Replace file with cleaned version below.

bun.lockb: don’t include binary lockfile in diff.

@Omar8345
Copy link
Author

@louis030195 quick reminder

@Excellencedev
Copy link

@louis030195 quick reminder

@Omar8345 they're not maintaining this repo again
it's just terminator now

@Omar8345
Copy link
Author

@louis030195 quick reminder

@Omar8345 they're not maintaining this repo again it's just terminator now

i just don't get it, why am i not compensated for my time? commits were active at the time of pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants