-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: implement search history for search pipe #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* add persistent search history storage * display previous searches in sidebar * allow selecting, renaming, and deleting history items * update lockb
🧪 testing bounty created!a testing bounty has been created for this PR: view testing issue testers will be awarded $20 each for providing quality test reports. please check the issue for testing requirements. |
|
Hi @louis030195, just a friendly nudge on this PR 🙏 No rush, but since it’s connected to a bounty I’d be grateful if you could take a look when you have time. Thanks! |
|
@louis030195 please take this seriously. 3 weeks? |
@Omar8345 It is something they do in their free time. Calm down and stop spamming or you will likely get banned |
thanks for your advice |
|
@louis030195 mind checking this please?? |
|
@Omar8345 close this pr and open a new one if u want someone to review it |
Excellencedev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so many unnecessary and wrong changes. refactor this pr
Excellencedev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR has major merge artifacts and invalid code.
page.tsx: duplicated JSX → app won’t compile. Keep single
search-chat.tsx: repeated imports + states; merge conflict remnants — keep one clean version only.
use-search-history.tsx: completely broken; two storage keys, async/sync mix, missing braces. Replace file with cleaned version below.
bun.lockb: don’t include binary lockfile in diff.
|
@louis030195 quick reminder |
@Omar8345 they're not maintaining this repo again |
i just don't get it, why am i not compensated for my time? commits were active at the time of pr |
name: pull request
about: submit changes to the project
title: "[pr] implement search history for search pipe"
labels: 'feature, ui, enhancements'
assignees: '@Omar8345'
description
This PR implements persistent search history for the search pipe. Users can now see previous searches in the sidebar, select a search to reload it, rename history items, and delete them. The changes include both UI updates and backend storage for maintaining history across sessions.
related issue: #1382
how to test
search.history.-.search.pipe.mov
/claim #1382