Feature/patch bom alternative #58
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinleim
reviewed
Jun 19, 2024
Member
martinleim
left a comment
martinleim
left a comment
There was a problem hiding this comment.
I am not fully through, but I think we should discuss the overall approach of the patch process.
core/src/main/java/de/medavis/lct/core/metadata/ComponentMetaDataLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/medavis/lct/core/patcher/ComponentMetaDataManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/medavis/lct/core/patcher/ComponentMetaDataManager.java
Outdated
Show resolved
Hide resolved
martinleim
requested changes
Jul 11, 2024
Member
martinleim
left a comment
martinleim
left a comment
There was a problem hiding this comment.
Hi @elomagic, summary of our discussion:
Patcher will be reworked so that it
- Read components from BOM
- Compares each component against the configured meta data. If there is a match, check if has licenses configured and replace the licenses from BOM wth those from the configured meta data
- Normalize license name against those configured in license mapping data
- Use license IDs and URL from configured license data
- Patch BOM by overwriting the licenses of each component with the licenses obtained from the previous steps.
martinleim
reviewed
Aug 8, 2024
core/src/main/resources/de/medavis/lct/core/patcher/DefaultLicenseMapping.json5
Outdated
Show resolved
Hide resolved
core/src/main/resources/de/medavis/lct/core/patcher/SpdxLicenseList.json5
Outdated
Show resolved
Hide resolved
core/src/test/java/de/medavis/lct/core/patcher/ComponentMetaDataManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/resources/de/medavis/lct/core/patcher/test-rules.json5
Outdated
Show resolved
Hide resolved
jenkins/src/main/java/de/medavis/lct/jenkins/patch/BomPatcherBuilder.java
Outdated
Show resolved
Hide resolved
# Conflicts: # cli/src/main/java/de/medavis/lct/cli/Main.java # core/src/main/java/de/medavis/lct/core/asset/AssetLoader.java # core/src/main/java/de/medavis/lct/core/metadata/ComponentMetadata.java # core/src/test/java/de/medavis/lct/core/asset/AssetLoaderTest.java # doc/GlobalConfiguration.png # jenkins/src/main/java/de/medavis/lct/jenkins/config/ManifestGlobalConfiguration.java # jenkins/src/main/resources/de/medavis/lct/jenkins/config/ManifestGlobalConfiguration/config.jelly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.