Fix: make Locator.wait_for timeout safe
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyti
force-pushed
the
issue-55--locator.wait_for
branch
from
3e1fa39 to
33b83e6
Compare
Previously, failures due to the timeout being reached were treated as
unknown, unexpected errors. In such cases, `Channel.recv/2` would `raise`.
With this change, we can now match on `%Error{type: "TimeoutError"}`,
which avoids the `raise` and improves the API.
Note that the change also includes a small "hack": an attempt to ensure
that the related `GenServer` timeout does not occur before the
Playwright server timeout.
Fixes [issue #55](#55).
coreyti
force-pushed
the
issue-55--locator.wait_for
branch
from
33b83e6 to
ef07a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, failures due to the timeout being reached were treated as unknown, unexpected errors. In such cases,
Channel.recv/2would (and still does)raise.With this change, we can now match on
%Error{type: "TimeoutError"}, which avoids theraiseand improves the API.Note that the change also includes a small "hack": an attempt to ensure that the related
GenServertimeout does not occur before the Playwright server timeout.Fixes issue #55.