Implement basic versions of Page.Keyboard #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germsvel
force-pushed
the
implement-keyboard
branch
from
e4ffe54 to
3e12c00
Compare
What changed? ============= We implement a basic version of `Page.Keyboard` functions whose specs were commented out in the module. The test cases are the simplest versions I could come up with (having borrowed heavily from [Python's keyboard tests]) The implementation also follows [Python's implementations]. [Python's keyboard tests]: https://github.com/microsoft/playwright-python/blob/2402e1283de6049cb66ea8ec6f303ba681890d2a/tests/async/test_keyboard.py#L1 [Python's implementations]: https://github.com/microsoft/playwright-python/blob/2402e1283de6049cb66ea8ec6f303ba681890d2a/playwright/_impl/_input.py#L25-L38 Noteworthy Highlights ---------------------- 1. Our implementation takes a `%Page{}` struct rather than what the specs suggested (a `Keyboard.t()`). I don't know if it's possible to pass down a narrower type, but as far as I could tell `Page` had both the `session` and `guid` (which are needed for the `Channel.post` call). 2. We namespace `Playwright.Keyboard` under `Page` (i.e. `Playwright.Page.Keyboard`) to match the directory structure and since that seems to match the Playwright documentation as well. 3. Finally, we add a new `test/assets/` directory where we include a new `inputs/keyboard.html` page. That page is [copied directly from Python][keyboard.html], so it follows Python's style of testing. In particular, our tests needed the `getResult()` function to get the values back for our test assertions. [keyboard.html]: https://github.com/microsoft/playwright-python/blob/2402e1283de6049cb66ea8ec6f303ba681890d2a/tests/assets/input/keyboard.html#L1
coreyti
force-pushed
the
implement-keyboard
branch
from
3e12c00 to
2c3309c
Compare
A reasonable idea, but unnecessary: The [`playwright-assets`](https://github.com/mechanical-orchard/playwright-assets) dependency provides all of the test assets. Indeed, the `keyboard.html` file that was being utilized in the new keyboard tests is that from the `playwright-assets` server, and not this (removed) file in `test/assets`.
For the time being, Node packages are installed directly into `priv/static`, and utilized from there. This is not the desired long-term solution, but is what is needed for the moment.
200ms allows for some flakiness. Most things will still finish faster. If the event doesn't happen in 500ms, that's probably interesting, finally.
|
Hey @germsvel, thanks for the contribution! I made some adjustments in commits: Those are worth a quick look. And, any feedback/suggestions based on those would be great. The other 4 commits are not directly related to your changes, but came along in my rebasing (the PR revealed some missing changes needed). I've decided to be okay with having those "tag along" with your PR 🤷🤩 All that said, I'm happy to merge your change. Please continue. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We implement a basic version of
Page.Keyboardfunctions whose specs were commented out in the module.The test cases are the simplest versions I could come up with (having borrowed heavily from Python's keyboard tests)
The implementation also follows Python's implementations.
Noteworthy Highlights
Our implementation takes a
%Page{}struct rather than what the specs suggested (aKeyboard.t()). I don't know if it's possible to pass down a narrower type, but as far as I could tellPagehad both thesessionandguid(which are needed for theChannel.postcall).We namespace
Playwright.KeyboardunderPage(i.e.Playwright.Page.Keyboard) to match the directory structure and since that seems to match the Playwright documentation as well.Finally, we add a new
test/assets/directory where we include a newinputs/keyboard.htmlpage. That page is copied directly from Python, so it follows Python's style of testing. In particular, our tests needed thegetResult()function to get the values back for our test assertions.