Skip to content

Remove TypeScript moving parts #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Jun 20, 2025

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

When MDX TypeScript support is already provided through the TS plugin, the language server's TypeScript moving parts seem unnecessary, and I think it can be removed along with the tsdk option to simplify IDE integration.

Copy link

changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Latest commit: d8a93ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jun 20, 2025
@johnsoncodehk johnsoncodehk marked this pull request as draft June 23, 2025 09:03
@remcohaszing
Copy link
Member

Description of changes

When MDX TypeScript support is already provided through the TS plugin, the language server's TypeScript moving parts seem unnecessary, and I think it can be removed along with the tsdk option to simplify IDE integration.

I agree it’s better to configure TypeScript support with the TypeScript plugin, not the language server. It’s still supported by the language server, because this may be needed for some editors. I don’t know if this is the case.

It’s nice that we have this. :)

  • When language server doesn't need TS support, the file watcher doesn't seem to be needed anymore.

Isn’t this needed for the markdown language service?

remark plugins register syntax extensions. For example, markdown directives may yield syntax errors unless the remark-directive plugin is added. virtualCodePlugins is needed for TypeScript indeed. But it’s also very useful to be able to inspect the generated virtual code. I think this can only be inspected via the language server, not via the TypeScript plugin.

@remcohaszing remcohaszing self-requested a review June 26, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤞 phase/open Post is being triaged manually
Development

Successfully merging this pull request may close these issues.

2 participants