Skip to content

feat(css): Update syntax for <basic-shape> #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

feat(css): Update syntax for <basic-shape> #971

merged 1 commit into from
Apr 4, 2025

Conversation

skyclouds2001
Copy link
Contributor

Description

add support for the new xywh() and rect() syntax

Motivation

Additional details

https://drafts.csswg.org/css-shapes/#typedef-basic-shape

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review April 4, 2025 10:25
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner April 4, 2025 10:25
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team April 4, 2025 10:25
pepelsbey
pepelsbey approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit d4bc9b3 into mdn:main Apr 4, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 4, 2025
Merged
@skyclouds2001 skyclouds2001 deleted the basic-shape branch April 4, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @pepelsbey