[Technical review] BiDi - Add pages for new, status, and end commands of the session module#43251
Open
[Technical review] BiDi - Add pages for new, status, and end commands of the session module#43251
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following pages:
sessionlisting pagesession.newsession.statussession.endIt also updates:
webdriver.yaml)Additional details
Since BiDi builds on capabilities and errors defined in Classic, we can share a lot of those pages between the two.
So it might make sense to move them to common location under
Web/WebDriver/Referenceand out of the folders underWeb/WebDriver/Reference/Classicwhere they currently sit.Web/WebDriver/Referenceso that both Classic and BiDi commands can link to them.I'll make these changes in a separate PR.
@whimboo pointed out that the top landing page https://developer.mozilla.org/en-US/docs/Web/WebDriver is also in need of an update since the addition of our BiDi section - I'll update this page along with the above structural changes.
Spec links
session.new: https://w3c.github.io/webdriver-bidi/#command-session-newsession.status: https://w3c.github.io/webdriver-bidi/#command-session-statussession.end: https://w3c.github.io/webdriver-bidi/#command-session-endRelated issue
Doc issue: mdn/mdn#339