Skip to content

doc(api): IntersectionObserver rootMargin option value #40516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025

Conversation

ShubhamOulkar
Copy link
Contributor

@ShubhamOulkar ShubhamOulkar commented Jul 24, 2025

closes #40515

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner July 24, 2025 04:19
@ShubhamOulkar ShubhamOulkar requested review from sideshowbarker and removed request for a team July 24, 2025 04:19
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

@ShubhamOulkar ShubhamOulkar changed the title Update IntersectionObserver.rootMargin value doc(api): IntersectionObserver.rootMargin value Jul 24, 2025
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sideshowbarker sideshowbarker removed their request for review July 24, 2025 06:09
@ShubhamOulkar
Copy link
Contributor Author

ShubhamOulkar commented Jul 24, 2025

@ShubhamOulkar ShubhamOulkar changed the title doc(api): IntersectionObserver.rootMargin value doc(api): IntersectionObserver rootMargin option value Jul 24, 2025
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed size/xs [PR only] 0-5 LoC changed and removed size/xs [PR only] 0-5 LoC changed size/s [PR only] 6-50 LoC changed labels Jul 28, 2025
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jul 28, 2025
@ShubhamOulkar ShubhamOulkar requested a review from Josh-Cena July 28, 2025 14:43
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Apparently this is a spec bug: w3c/IntersectionObserver#308

@Josh-Cena Josh-Cena merged commit 1b61fe3 into mdn:main Jul 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntersectionObserver rootMargin option can only be in pixels or percentage
2 participants