Skip to content

Lint: prefer Object.hasOwn, avoid eval #39668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Lint: prefer Object.hasOwn, avoid eval #39668

merged 1 commit into from
May 27, 2025

Conversation

Josh-Cena
Copy link
Member

Remove usage of hasOwnProperty to promote good practices. Avoid unnecessary usage of eval.

@Josh-Cena Josh-Cena requested review from a team as code owners May 25, 2025 09:25
@Josh-Cena Josh-Cena requested review from chrisdavidmills, hamishwillee and wbamberg and removed request for a team, chrisdavidmills, hamishwillee and wbamberg May 25, 2025 09:25
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:HTTP HTTP docs labels May 25, 2025
@Josh-Cena Josh-Cena requested a review from bsmth May 25, 2025 09:26
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label May 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (11 pages)
Flaws (3)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Guides/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file
Title: Proxy Auto-Configuration (PAC) file
Flaw count: 3

  • unknown:
    • No generic content config found
    • no blog root
    • no blog root
External URLs (1)

URL: /en-US/docs/Web/JavaScript/Guide/Expressions_and_operators
Title: Expressions and operators

bsmth
bsmth approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicer, thanks. One question for you, but not blocking.

@Josh-Cena Josh-Cena merged commit 847f754 into mdn:main May 27, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the object-hasown branch May 27, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @bsmth