issue #251 #269
Open
issue #251 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoganwr
requested changes
Mar 17, 2025
There was a problem hiding this comment.
The identifiers for the new classes you created are not OBO compliant. You cannot use UUIDs. We can work through the required Protege settings to create proper IDs.
You cannot change the definitions of IAO classes. We need to check that all IAO is being imported and that there is no longer any copy and paste into omrse-edit.owl.
|
Apologies, I take back the bit about IAO class definitions. We were going to do the obsoletion of the old stuff in this PR, or a separate one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes agreed upon during OMRSE meeting, 5 March 2025, including all four new terms proposed by @CDowland (issue #251)