report TX error condition with special LED state #316
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusefillc
changed the title
mck1117
reviewed
Apr 24, 2024
firmware/main.cpp
Outdated
| @@ -60,7 +61,11 @@ int main() { | |||
| /* TODO: show EGT errors */ | |||
| auto fault = GetCurrentFault(0); | |||
|
|
|||
| if (fault == Fault::None) | |||
| if (isTxIssue()) { | |||
There was a problem hiding this comment.
why not register a fault using the existing fault infra?
There was a problem hiding this comment.
because blink-encoding is hard for humans
mck1117
reviewed
Apr 24, 2024
firmware/main.cpp
Outdated
| // temporary solution: light up both LEDs in case of TX error | ||
| palSetPad(LED_BLUE_PORT, LED_BLUE_PIN); | ||
| palSetPad(LED_BLUE_PORT, LED_GREEN_PIN); | ||
| } else if (fault == Fault::None) |
rusefillc
added a commit
to rusefi/wideband
that referenced
this pull request
Apr 24, 2024
rusefillc
added a commit
to rusefi/wideband
that referenced
this pull request
Apr 24, 2024
rusefillc
force-pushed
the
track-tx-error
branch
from
a1ddaa2 to
d0d51f0
Compare
rusefillc
added a commit
to rusefi/wideband
that referenced
this pull request
Apr 24, 2024
rusefillc
force-pushed
the
track-tx-error
branch
from
d0d51f0 to
389cf57
Compare
rusefillc
force-pushed
the
track-tx-error
branch
from
389cf57 to
d20c0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.