Prevent Duplicate Metrics #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In some situations, Gatekeeper exports duplicate records of violations e.g. open-policy-agent/gatekeeper#481 - If duplicates exist, the opa-gatekeeper previously would fail to serve metrics with a message like `collected metric <metric-details> was collected before with the same name and label values` - Patch to ensure the set of metrics exported by opa-scorecard will never contain duplicates - Since maps are not thread-safe, introduce read/write locks when working with the new global metrics map
Prevent duplicate metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where exporter-go fails to export Prometheus metrics if the cluster opa-gatekeeper has exported duplicate violations, e.g. because of open-policy-agent/gatekeeper#481
Symptom: https://opa-gatekeeper:9141/metrics returns
500 Internal Server Errorwith a message likecollected metric <metric-details> was collected before with the same name and label values