refactor: experiment with callers providing buffers #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchstats: 9f05ba1...65c8e2eView full benchmark output on the workflow summary. |
mccutchen
force-pushed
the
callers-provide-buffers
branch
from
ae16ac8 to
e737601
Compare
mccutchen
added a commit
that referenced
this pull request
Jan 22, 2025
The idea here is that there are some test cases (e.g. in the 9.* suite
that send extremely large frames/messages) where our implementation
appears to be painfully slow, so being able to run specific autobahn
tests against an external server like
make testautobahn AUTOBAHN_CASES=9.2.6 AUTOBAHN_TARGET=localhost:8080
will hopefully make it easier to gain visibility into performance
issues. (See also #23 for one potential path towards optimization.)
mccutchen
force-pushed
the
callers-provide-buffers
branch
2 times, most recently
from
65c8e2e to
8129de5
Compare
|
🔥 Run benchmarks comparing a275f8e against gh workflow run bench.yaml -f pr_number=23Note: this comment will update with each new commit. |
benchstats: 4e63a4d...a275f8eView full benchmark output on the workflow summary. |
mccutchen
force-pushed
the
callers-provide-buffers
branch
from
99e2e55 to
449ce8c
Compare
mccutchen
force-pushed
the
callers-provide-buffers
branch
from
449ce8c to
a275f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not particularly happy with the specific implementation here, but want to figure out what this kind of change does to allocations. Ultimately, would like to enable using a sync.Pool of buffers when reading frames and messages from the wire, but I'm not sure what the API should look like.