Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add highlight JS #9

Closed
wants to merge 2 commits into from
Closed

feat: Add highlight JS #9

wants to merge 2 commits into from

Conversation

ahmedsaheed
Copy link

This add supports of code block highlighting via markdown-it-highlightjs.
It should also close post by @mb21 in mb21/panwriter#96 (comment)

@mb21
Copy link
Owner

mb21 commented Dec 26, 2022

Thanks for the pull request! Seems you run an auto-formatter over the code, was it Prettier? I'm not opposed to doing that, but would be great if it's a separate commit, otherwise it's hard to see what else was changed.

@ahmedsaheed
Copy link
Author

Yes, ran prettier over the code. But the main change is in the second commit

@mb21
Copy link
Owner

mb21 commented Dec 26, 2022

The second commit simply adds , {auto: true}? But whatever, if it's well tested, I can add it quickly myself if that's okay for you as well...

@ahmedsaheed ahmedsaheed closed this by deleting the head repository Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants