Skip to content
This repository was archived by the owner on Dec 22, 2022. It is now read-only.

Add files via upload #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afifswaidan
Copy link

No description provided.

@@ -23,74 +23,36 @@
import time

# driver = DobotDriver('COM4')
driver = DobotDriver('/dev/tty.usbmodem1421')
driver = DobotDriver('COM4')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retain the original com port as an example for windows already exists and is commented out above.

while not ret[1]:
ret = driver.Steps(steps1, steps2, steps3, 1, 0, 1, gripper, toolRotation)

time.sleep(3)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retain interval for demo purposes.


# exit(0)

freq = [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal doesn't seem necessary, please retain the example code. If this example is not exactly what you'd like to have, please feel free to create another example or split this one.

@@ -0,0 +1,243 @@
#! /usr/bin/env python
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name the file to reflect the purpose instead of part of name.

@@ -21,17 +21,15 @@
import time

# The top Z to go to.
up = 50
up = 100
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be a safe value.

# Maximum speed in mm/s
speed = 400
# Acceleration in mm/s^2
acceleration = 300

# dobot = Dobot('/dev/tty.usbmodem1421', debug=True, fake=True)
# dobot = Dobot('COM4', debug=True)
dobot = Dobot('/dev/tty.usbmodem1421', debug=True)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retain the port statements for demo purposes.

@@ -0,0 +1,35 @@
import math
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe what this module's purpose is.

@@ -0,0 +1,19 @@
from dobot import DobotDriver
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name the file to reflect that it is an example instead of part of your name.

@@ -0,0 +1,5 @@
<RCC>
<qresource prefix="res">
<file>logo.jpg</file>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a file named logo.jpg in the PR. Did I miss it?

@maxosprojects
Copy link
Owner

Communication moved from an off-topic issue:

Hello, I am continuing the development on the dobot arm as I am a mechatronics engineering student in my senior year currently.
I am trying to add realtime accelerometers reporting to use them as a negative feedback loop during the movement of the arm. I edited the firmware to send to me static values that I set for testing whenever I call the getaccelrometers() function from the dobot SDK.
I also added many other features (gui and interactive user input through terminal) and fixed a few math errors in the dobot kinematics.
Thanks for the great work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants