Skip to content

Conversation

@setchy
Copy link
Contributor

@setchy setchy commented Jun 25, 2024

  1. Run ncu -u to update deps
  2. reconfigure typedoc (typedoc.json)
  3. generate new /docs via yarn docs

@setchy
Copy link
Contributor Author

setchy commented Jun 25, 2024

pending merge of #478

@setchy
Copy link
Contributor Author

setchy commented Oct 10, 2025

@amaury1093 - i've refreshed this pr which bumps all deps to their latest version and renegerates the typedocs. this brings menubar up to electron 38.x

Comment on lines +7 to +8
import path from 'node:path';
import url from 'node:url';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly worried this will impact some users in some unexpected ways. Can you give me reassurance this won't?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import changes which add 'node: prefix is addressing this biome linter rule: https://biomejs.dev/linter/rules/use-nodejs-import-protocol/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has quite a number of dep upgrades,we could release as a new major or minor version (not patch)

@setchy setchy requested review from amaury1093 and gobengo October 10, 2025 16:52
@RobbieTheWagner
Copy link
Contributor

Would love to have support up to Electron 38! 🎉

Signed-off-by: Adam Setch <[email protected]>
@setchy
Copy link
Contributor Author

setchy commented Oct 28, 2025

updated to include electron v39

@RobbieTheWagner
Copy link
Contributor

@amaury1093 if you are able to add me as a maintainer, I would be glad to help out with keeping things up to date.

@amaury1093
Copy link
Collaborator

@amaury1093 if you are able to add me as a maintainer, I would be glad to help out with keeping things up to date.

I'm not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants