Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: keep config persistent after reset or restart if the stream is unavailable during restart #465

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YehorFedorov
Copy link

Once I added the restart_streams API I found that manager::start_default function has the next line

    // Gently remove all streams as we are going to replace the entire list below
    remove_all_streams().await?;

Which was removing the full configuration. After a restart, the config contains the streams that were available during the restart and other disappeared

remove_all_streams is only called from start_default, so I decided to resolve this simply by providing a flag, that allow or prevent the config file from modification

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants