Skip to content

Add Japanese language support #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soma3978 wants to merge 6 commits into
base: dev
Choose a base branch
from
+2,405 −4
Open

Add Japanese language support #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75ef928
Create ja.ts
soma3978 Apr 22, 2026
1084d40
Update TranslationContext.tsx
soma3978 Apr 22, 2026
0d0ab50
Update supportedLanguages.ts
soma3978 Apr 22, 2026
9bf4220
Update ja.ts
soma3978 Apr 22, 2026
d301321
Update client/src/i18n/translations/ja.ts
soma3978 Apr 22, 2026
73fb48e
Update index.test.ts
soma3978 Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client/src/i18n/TranslationContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import ar from './translations/ar'
import br from './translations/br'
import cs from './translations/cs'
import pl from './translations/pl'
import ja from './translations/ja'
import { SUPPORTED_LANGUAGES, SupportedLanguageCode } from './supportedLanguages'

export { SUPPORTED_LANGUAGES }
Expand All @@ -23,7 +24,7 @@ type TranslationStrings = Record<string, string | { name: string; category: stri

// Keyed by SupportedLanguageCode so TypeScript enforces all languages have a translation.
const translations: Record<SupportedLanguageCode, TranslationStrings> = {
de, en, es, fr, hu, it, ru, zh, 'zh-TW': zhTw, nl, id, ar, br, cs, pl,
de, en, es, fr, hu, it, ru, zh, 'zh-TW': zhTw, nl, id, ar, br, cs, pl, ja,
}

// Derived from SUPPORTED_LANGUAGES — add new languages there, not here.
Expand All @@ -38,7 +39,7 @@ export function getLocaleForLanguage(language: string): string {

export function getIntlLanguage(language: string): string {
if (language === 'br') return 'pt-BR'
return ['de', 'es', 'fr', 'hu', 'it', 'ru', 'zh', 'zh-TW', 'nl', 'ar', 'cs', 'pl', 'id'].includes(language) ? language : 'en'
return ['de', 'es', 'fr', 'hu', 'it', 'ru', 'zh', 'zh-TW', 'nl', 'ar', 'cs', 'pl', 'id', 'ja' ].includes(language) ? language : 'en'
}
Comment on lines 40 to 43
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s an extra space before the closing bracket in the language allowlist ('ja' ]). Please remove it (and consider deriving this allowlist from SUPPORTED_LANGUAGES to avoid future drift).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@soma3978 soma3978 Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback


export function isRtlLanguage(language: string): boolean {
Expand Down
3 changes: 2 additions & 1 deletion client/src/i18n/supportedLanguages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ export const SUPPORTED_LANGUAGES = [
{ value: 'zh', label: '简体中文', locale: 'zh-CN' },
{ value: 'zh-TW', label: '繁體中文', locale: 'zh-TW' },
{ value: 'it', label: 'Italiano', locale: 'it-IT' },
{ value: 'ar', label: 'العربية', locale: 'ar-SA' },
{ value: 'ar', label: 'العربية', locale: 'ar-SA' },
{ value: 'id', label: 'Bahasa Indonesia', locale: 'id-ID' },
{ value: 'ja', label: '日本語', locale: 'ja-JP' },
] as const

export type SupportedLanguageCode = typeof SUPPORTED_LANGUAGES[number]['value']
Expand Down
Loading
Loading