Skip to content

Preserve drop_rows when materializing model specifications - #286

Open
AryanRG wants to merge 1 commit into
matthewwardrop:mainfrom
AryanRG:fix/forward-drop-rows
Open

AryanRG wants to merge 1 commit into
matthewwardrop:mainfrom
AryanRG:fix/forward-drop-rows

Conversation

@AryanRG

@AryanRG AryanRG commented Oct 23, 2026

Copy link
Copy Markdown

drop_rows is lost when ModelSpec.get_model_matrix() applies attribute overrides, and when structured ModelSpecs share a materializer. Rows requested for exclusion can therefore remain in the returned matrices.

Forward the same set through both paths so explicit exclusions and rows dropped for missing values stay aligned. The regressions cover structured/unstructured specs and pandas, NumPy and sparse outputs.

The full local pytest run and pinned Ruff/mypy checks passed on Python 3.12. Existing suite skips are unchanged.

Preserve the caller-provided exclusion set when applying attribute overrides and when materializing structured model specifications together. Cover row alignment and missing-value updates across supported output types.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant