Repository navigation
Conversation
Preserve the caller-provided exclusion set when applying attribute overrides and when materializing structured model specifications together. Cover row alignment and missing-value updates across supported output types.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drop_rowsis lost whenModelSpec.get_model_matrix()applies attribute overrides, and when structuredModelSpecsshare a materializer. Rows requested for exclusion can therefore remain in the returned matrices.Forward the same set through both paths so explicit exclusions and rows dropped for missing values stay aligned. The regressions cover structured/unstructured specs and pandas, NumPy and sparse outputs.
The full local pytest run and pinned Ruff/mypy checks passed on Python 3.12. Existing suite skips are unchanged.