Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284.
Formula("center(x)").required_variablesreturns an empty set instead of{"x"}, even though generating its model matrix usesx. The default no-op variable getter still evaluates the transform call's arguments during introspection. Without data, this raisesNameError, whichFactor.required_variablesandToken.required_variablessuppress.Keep absent variable getters as
None, and delegate extraction only when a transform has an explicit getter. Ordinary stateful transforms then use the existing AST traversal without evaluating their arguments. Explicit getters, includingQ()for quoted column names, remain active.Validation on Windows with Python 3.12.14:
No performance benchmark or other Python-version run was performed locally.