Repository navigation
Drop missing observations by position for duplicate pandas indexes - #276
Open
lllleolin-max wants to merge 1 commit into
Open
lllleolin-max wants to merge 1 commit into
lllleolin-max wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a DataFrame has duplicate index labels and one observation is missing, dropping its index label also drops valid observations with the same label. This either loses data or makes generated columns disagree with the final index. Drop rows by position consistently in the Series helper,
C()encoder and final pandas index. Regression tests compare numeric, categorical and explicitC()formulas against the same retained observations with unique indexes across pandas, NumPy and sparse output.Validation: the added regression tests fail on main (
81e675b) and pass with this patch. Related tests:python -m pytest tests/materializers/test_pandas.py tests/utils/test_null_handling.py tests/transforms/test_contrasts.py -q. Changed files passruff checkandruff format.