Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Slack-to-Mattermost migration documentation to improve accuracy, clarity, and alignment with current tooling. The updates remove references to the deprecated slack_advanced_exporter tool, add a validation step using mmetl check slack, correct terminology around Slack export types, fix numerous spelling and grammar errors, and refine configuration guidance.
Changes:
- Removed deprecated
slack_advanced_exportertool instructions and streamlined to focus on the officially supportedmmetltool - Added validation step for Slack exports before transformation using
mmetl check slack - Corrected multiple spelling and grammar errors throughout the document (necessary, enough, additional, associated, Starred, Threaded conversations)
- Updated Slack export type terminology to "Public channels export" and "All channels and conversations export" with clarified descriptions
- Fixed configuration guidance for
TeamSettings.MaxChannelsPerTeamand removed extra space inElasticsearchSettings.EnableIndexing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Newest code from mattermost has been published to preview environment for Git SHA 92255d6 |
1 similar comment
|
Newest code from mattermost has been published to preview environment for Git SHA 92255d6 |
|
|
||
| .. code-block:: sh | ||
|
|
||
| mmctl import validate ./mattermost-bulk-import.zip |
There was a problem hiding this comment.
Does this command work on local files or on files already uploaded? The syntax here is for local files.
There was a problem hiding this comment.
I tested it with the local zip file. But it should work with both local and uploaded, since it's basically same zip at different locations. In anycase, I've moved the validation step before the upload step to make the flow clear and also improved the explanation wording a bit.
| - ``--allow-download`` / ``-l``: Allow downloading attachments from URLs. | ||
| - ``--default-email-domain <DOMAIN>``: When a user's email is missing from the export, generate one from their username and the provided domain (e.g., ``--default-email-domain example.com``). | ||
| - ``--skip-empty-emails``: Allow users with empty email addresses to be included in the output. Note that this results in invalid import data that will need to be manually corrected before importing. | ||
| - ``--discard-invalid-props`` / ``-p``: Discard posts with invalid properties instead of skipping them entirely. |
There was a problem hiding this comment.
The description for --discard-invalid-props says posts will be discarded and also says "without skipping them entirely". It's unclear what that means. In code the comment says, "Skips converting posts with invalid props instead discarding the props themselves". I don't think the whole post is discarded, just the invalid props.
There was a problem hiding this comment.
The flag name should be updated here. As it discards the post with invalid props. https://github.com/mattermost/mmetl/blob/1f79651dd06b1465f59a44c335cd759ce5dc7e58/services/slack/intermediate.go#L675
And yes, the earlier desc. was confusing. I've improved the wording here.
Also, we should improve the desc. in the code as well as it also seems a bit confusing. https://github.com/mattermost/mmetl/blob/1f79651dd06b1465f59a44c335cd759ce5dc7e58/commands/transform.go#L50
|
|
||
| commit; | ||
|
|
||
| Additional tools |
There was a problem hiding this comment.
Are these tools no longer needed? If so, can we add a line explaining why?
There was a problem hiding this comment.
It's mentioned in the PR description: 🙂
- Removed the Additional Tools subsection (mm-emoji, mmimportjs, slack-migrate-pinned-posts) as they are archived, broken, or no longer maintained
cwarnermm
added
1: Dev Review
|
Newest code from mattermost has been published to preview environment for Git SHA c88dbd1 |
3 participants
PS: I've not tested it with the Enterprise export. So, no changes around that.