Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spin server when Tests start #3316

Merged
merged 31 commits into from
Mar 26, 2025
Merged

Spin server when Tests start #3316

merged 31 commits into from
Mar 26, 2025

Conversation

yasserfaraazkhan
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Feb 7, 2025 •
edited
Loading

image
  • Removed posting comment on PR with pass or fail results
  • Added status check in the PR
  • We can access results by clicking on e2e/windows or e2e/macos it'll open up the html report

It'll be less noise on the PR.

NONE

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

E2E Test Results

Linux Results:

macOS Results:

Windows Results:

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 7, 2025
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 14, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 14, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 14, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 14, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 14, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 14, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 15, 2025
@mattermost mattermost deleted a comment from github-actions bot Feb 15, 2025
@mattermost mattermost deleted a comment from github-actions bot Feb 15, 2025
@mattermost mattermost deleted a comment from github-actions bot Feb 15, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 15, 2025
@mattermost mattermost deleted a comment from github-actions bot Feb 16, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 16, 2025
@github-actions GitHub Actions
Copy link

E2E Test Results

Linux Results:

macOS Results:

Windows Results:

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 16, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 16, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 12, 2025
@yasserfaraazkhan yasserfaraazkhan requested review from hmhealey and removed request for saturninoabril March 19, 2025 08:38
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 19, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 19, 2025
hmhealey
hmhealey approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

.github/actions/install-os-dependencies/action.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be doing anything to pin versions of dependencies? I feel like that's not often done for these sorts of things, so it's probably fine either way, but I thought I'd at least mention it

@hmhealey hmhealey added the 4: Reviews Complete All reviewers have approved the pull request label Mar 21, 2025
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 26, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 26, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 26, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 26, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 26, 2025
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Mar 26, 2025
@yasserfaraazkhan yasserfaraazkhan enabled auto-merge (squash) March 26, 2025 17:59
@yasserfaraazkhan yasserfaraazkhan merged commit aa4ee31 into master Mar 26, 2025
12 checks passed
@yasserfaraazkhan yasserfaraazkhan deleted the server-on-the-go branch March 26, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@yasserfaraazkhan yasserfaraazkhan

Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yasserfaraazkhan @hmhealey @devinbinnie @mm-cloud-bot @mattermost-build