Skip to content

Commit

Permalink
Merge pull request #727 from matter-labs/dvush/adatpt-our-kubeconfigmap
Browse files Browse the repository at this point in the history
Remove prefixes, useless env
  • Loading branch information
dvush authored Jun 12, 2020
2 parents 96bb96d + 13de4bb commit 63e2b33
Show file tree
Hide file tree
Showing 10 changed files with 33 additions and 55 deletions.
2 changes: 1 addition & 1 deletion bin/k8s-configmap
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#. .setup_env prod

kubectl create configmap $ZKSYNC_ENV-configmap --namespace $ZKSYNC_ENV --dry-run -o yaml
kubectl create configmap configmap --namespace $ZKSYNC_ENV --dry-run -o yaml
echo data:
while read -r line; do
VAR=`sed 's/=.*//' <<< $line`
Expand Down
2 changes: 1 addition & 1 deletion bin/prover
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ NUM_OF_PROVERS=${1:-1}
pids=( ) # initialize an empty array to store PIDs

for n in `eval echo {1..$NUM_OF_PROVERS}`; do
PROVER_BASE_NAME="$POD_NAME"_"$n"_blocks_
PROVER_BASE_NAME="$HOST_NAME"_"$n"_blocks_
cargo run --release --bin plonk_step_by_step_prover $PROVER_BASE_NAME > /dev/null & pid="$!"
pids+=( "$pid" )
echo "prover $PROVER_BASE_NAME with pid $pid"
Expand Down
2 changes: 0 additions & 2 deletions core/models/src/config_options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ impl ProverOptions {

#[derive(Debug, Clone)]
pub struct ConfigurationOptions {
pub replica_name: String,
pub rest_api_server_address: SocketAddr,
pub json_rpc_http_server_address: SocketAddr,
pub json_rpc_ws_server_address: SocketAddr,
Expand Down Expand Up @@ -136,7 +135,6 @@ impl ConfigurationOptions {
let mut available_block_chunk_sizes = block_chunk_sizes().to_vec();
available_block_chunk_sizes.sort();
Self {
replica_name: parse_env("SERVER_REPLICA_NAME"),
rest_api_server_address: parse_env("REST_API_BIND"),
json_rpc_http_server_address: parse_env("HTTP_RPC_API_BIND"),
json_rpc_ws_server_address: parse_env("WS_API_BIND"),
Expand Down
2 changes: 0 additions & 2 deletions docker/prover/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ FROM alpine
# Docs of env variables used for this image
# to test this locally just run
# docker build -t tmp_prover -f =(f envsubst < ./docker/prover/Dockerfile) .; docker run --rm tmp_prover:latest
#ENV NODE_NAME nodename
#ENV POD_NAME podname
#ENV SUPPORTED_BLOCK_CHUNKS_SIZES $SUPPORTED_BLOCK_CHUNKS_SIZES
#ENV SUPPORTED_BLOCK_CHUNKS_SIZES_SETUP_POWERS $SUPPORTED_BLOCK_CHUNKS_SIZES_SETUP_POWERS
#ENV BLOCK_CHUNK_SIZES $BLOCK_CHUNK_SIZES
Expand Down
6 changes: 3 additions & 3 deletions docker/prover/prover-entry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
export ZKSYNC_HOME="/"

echo NODE_NAME=$NODE_NAME
echo POD_NAME=$POD_NAME
echo PROVER_NAME=`hostname`

echo SUPPORTED_BLOCK_CHUNKS_SIZES=$SUPPORTED_BLOCK_CHUNKS_SIZES
echo SUPPORTED_BLOCK_CHUNKS_SIZES_SETUP_POWERS=$SUPPORTED_BLOCK_CHUNKS_SIZES_SETUP_POWERS
Expand All @@ -12,7 +12,7 @@ echo BLOCK_CHUNK_SIZES=$BLOCK_CHUNK_SIZES

if [ "$DOCKER_DUMMY_PROVER" == "true" ]; then
echo "Starting dummy_prover"
exec dummy_prover "$POD_NAME" 2>&1
exec dummy_prover "$PROVER_NAME" 2>&1
fi

# we download only keys used in node (defined by $BLOCK_CHUNK_SIZES)
Expand All @@ -28,4 +28,4 @@ fi

echo key download complete, starting prover

exec plonk_step_by_step_prover "$POD_NAME" 2>&1
exec plonk_step_by_step_prover "$PROVER_NAME" 2>&1
4 changes: 0 additions & 4 deletions etc/env/dev.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ RUST_LOG=storage=info,server=debug,prover=debug,plasma=info,eth_client=info,data
# Server container kubernetes resoruces.
SERVER_CONTAINER_RESOURCES="{\"requests\": {\"cpu\": 2, \"memory\": \"500Mi\"}}"

POD_NAME=default-prover-pod-name

IMAGE_TAG=$(lasthash=$(git rev-parse HEAD) && echo ${lasthash:0:8})
ZKSYNC_ACTION=dont_ask

Expand All @@ -136,5 +134,3 @@ CONFIRMATIONS_FOR_ETH_EVENT=0
# poll interval milliseconds
ETH_WATCH_POLL_INTERVAL=300


SERVER_REPLICA_NAME=server-1
8 changes: 4 additions & 4 deletions etc/kube/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,21 @@ spec:
paths:
- path: /
backend:
serviceName: ${ZKSYNC_ENV}-server
serviceName: server
servicePort: 3000
- path: /jsrpc
backend:
serviceName: ${ZKSYNC_ENV}-server
serviceName: server
servicePort: 3030
- path: /jsrpc-ws
backend:
serviceName: ${ZKSYNC_ENV}-server
serviceName: server
servicePort: 3031
- host: ${EXPLORER_HOST}
http:
paths:
- path: /
backend:
serviceName: ${ZKSYNC_ENV}-nginx
serviceName: nginx
servicePort: 80

14 changes: 7 additions & 7 deletions etc/kube/nginx.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
apiVersion: v1
kind: Service
metadata:
name: ${ZKSYNC_ENV}-nginx
name: nginx
namespace: ${ZKSYNC_ENV}
labels:
app: ${ZKSYNC_ENV}-nginx
app: nginx
spec:
type: ClusterIP
ports:
Expand All @@ -13,25 +13,25 @@ spec:
protocol: TCP
name: http
selector:
app: ${ZKSYNC_ENV}-nginx
app: nginx
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: ${ZKSYNC_ENV}-nginx
name: nginx
namespace: ${ZKSYNC_ENV}
spec:
replicas: 1
selector:
matchLabels:
app: ${ZKSYNC_ENV}-nginx
app: nginx
template:
metadata:
labels:
app: ${ZKSYNC_ENV}-nginx
app: nginx
spec:
containers:
- name: ${ZKSYNC_ENV}-nginx
- name: nginx
image: matterlabs/nginx:${IMAGE_TAG}
imagePullPolicy: Always
ports:
Expand Down
21 changes: 6 additions & 15 deletions etc/kube/prover.yaml
Original file line number Diff line number Diff line change
@@ -1,37 +1,28 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: ${ZKSYNC_ENV}-prover
name: prover
namespace: ${ZKSYNC_ENV}
labels:
app: ${ZKSYNC_ENV}-prover
app: prover
spec:
strategy:
type: Recreate
replicas: 1
selector:
matchLabels:
app: ${ZKSYNC_ENV}-prover
app: prover
template:
metadata:
labels:
app: ${ZKSYNC_ENV}-prover
app: prover
spec:
containers:
- name: ${ZKSYNC_ENV}-prover
- name: prover
image: matterlabs/prover:${IMAGE_TAG}
imagePullPolicy: Always
resources: ${PROVER_MIN_RESOURCES}
envFrom:
- configMapRef:
name: ${ZKSYNC_ENV}-configmap
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: POD_NAME
valueFrom:
fieldRef:
fieldPath: metadata.name
name: configmap
terminationGracePeriodSeconds: 20
27 changes: 11 additions & 16 deletions etc/kube/server.yaml
Original file line number Diff line number Diff line change
@@ -1,50 +1,50 @@
apiVersion: v1
kind: Service
metadata:
name: ${ZKSYNC_ENV}-server
name: server
namespace: ${ZKSYNC_ENV}
annotations:
qoqo.dev/service-mode: active-standby
labels:
app: ${ZKSYNC_ENV}-server
app: server
spec:
type: ClusterIP
ports:
- port: 3000
targetPort: 3000
protocol: TCP
name: ${ZKSYNC_ENV}-server-rest
name: server-rest
- port: 3030
targetPort: 3030
protocol: TCP
name: ${ZKSYNC_ENV}-server-jsrpc
name: server-jsrpc
- port: 3031
targetPort: 3031
protocol: TCP
name: ${ZKSYNC_ENV}-server-jsrpc-ws
name: server-jsrpc-ws
- port: 8088
targetPort: 8088
protocol: TCP
name: ${ZKSYNC_ENV}-prover-server-port
name: prover-server-port
selector:
app: ${ZKSYNC_ENV}-server
app: server
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: ${ZKSYNC_ENV}-server
name: server
namespace: ${ZKSYNC_ENV}
spec:
strategy:
type: Recreate
replicas: 2
selector:
matchLabels:
app: ${ZKSYNC_ENV}-server
app: server
template:
metadata:
labels:
app: ${ZKSYNC_ENV}-server
app: server
spec:
containers:
- name: server
Expand All @@ -58,15 +58,10 @@ spec:
- containerPort: 8088
envFrom:
- configMapRef:
name: ${ZKSYNC_ENV}-configmap
name: configmap
env:
- name: ZKSYNC_ENV
value: "${ZKSYNC_ENV}"
- name: SERVER_REPLICA_NAME
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.name
- name: OPERATOR_PRIVATE_KEY
valueFrom:
secretKeyRef:
Expand Down

0 comments on commit 63e2b33

Please sign in to comment.