Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] fix: audit N-09 and N-12 #280

Closed
wants to merge 2 commits into from
+6 −6
Closed

[Draft] fix: audit N-09 and N-12 #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3e43d
fix: audit N-09
jcsec-security Feb 9, 2025
9c8cfef
fix: audit N-12
jcsec-security Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AAFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ contract AAFactory {

accountMappings[_uniqueAccountId] = accountAddress;

// Initialize the newly deployed account with validators, hooks and K1 owners.
// Initialize the newly deployed account with validators and K1 owners.
ISsoAccount(accountAddress).initialize(_initialValidators, _initialK1Owners);

emit AccountCreated(accountAddress, _uniqueAccountId);
Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/IHook.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { IERC165 } from "@openzeppelin/contracts/utils/introspection/IERC165.sol
import { IModule } from "./IModule.sol";

/// @title Validation hook interface for native AA
/// @author getclave.io
/// @author Based on https://getclave.io, modified version by Matter Labs
/// @notice Validation hooks trigger before each transaction,
/// can be used to enforce additional restrictions on the account and/or transaction during the validation phase.
interface IValidationHook is IModule, IERC165 {
Expand All @@ -18,7 +18,7 @@ interface IValidationHook is IModule, IERC165 {
}

/// @title Execution hook interface for native AA
/// @author getclave.io
/// @author Based on https://getclave.io, modified version by Matter Labs
/// @notice Execution hooks trigger before and after each transaction, during the execution phase.
interface IExecutionHook is IModule, IERC165 {
/// @notice Hook that triggers before each transaction during the execution phase.
Expand Down
4 changes: 2 additions & 2 deletions src/managers/HookManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import { IModule } from "../interfaces/IModule.sol";
/**
* @title Manager contract for hooks
* @notice Abstract contract for managing the enabled hooks of the account
* @dev Hook addresses are stored in a linked list
* @author https://getclave.io
* @dev Hook addresses are stored in an EnumerableSet
* @author Based on https://getclave.io, modified version by Matter Labs
*/
abstract contract HookManager is IHookManager, Auth {
using EnumerableSet for EnumerableSet.AddressSet;
Expand Down
2 changes: 1 addition & 1 deletion src/managers/OwnerManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { IOwnerManager } from "../interfaces/IOwnerManager.sol";
* @title Manager contract for owners
* @notice Abstract contract for managing the owners of the account
* @dev K1 Owners are secp256k1 addresses
* @dev Owners are stored in a linked list
* @dev Owners are stored in an EnumerableSet
* @author https://getclave.io
*/
abstract contract OwnerManager is IOwnerManager, Auth {
Expand Down