Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audit N-07 #278

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix: audit N-07 #278

merged 2 commits into from
Feb 10, 2025

Conversation

jcsec-security
Copy link
Collaborator

Description

Fix for the OZ audit issue N-07 "Function Visibility Overly Permissive"

The following recomendations were not followed as the current visibility was required for proper functioning:

  • The supportsInterface function in SsoAccount.sol with public visibility could be limited to external.
  • The supportsInterface function in TokenCallbackHandler.sol with public visibility could be limited to external.
  • The checkAndUpdate functions in SessionLib.sol with internal visibility could be limited to private.

Additional context

@ly0va ly0va merged commit 6579573 into main Feb 10, 2025
4 checks passed
@ly0va ly0va deleted the audit/N-07 branch February 10, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly0va ly0va ly0va approved these changes

Assignees
No one assigned
Labels
project: contracts security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcsec-security @ly0va