WIP: feat: OIDC account recovery #273
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: empty GuardianRecoveryValidator Created GuardianRecoveryValidator structure to start development * feat: methods to add a guardian implemented proposeRecoveryKey and addRecoveryKey with tests. * fix: reverting when guardian not found When a user tries to remove a guardian that does not exist we revert the tx. * fix: uint to uint256 Using uint256 instead of uint everywhere. * feat: add validateTransaction implementation to GuardianRecoveryValidatior * chore: refactor tests * chore: clean up code * feat: improve init method * feat: simplify initRecovery method * chore: resolve build issues * chore: resolve build issues * chore: resolve pr comments * feat: restore guardiansFor method * chore: remove unused access to accountGuardians * feat: make guardian recovery validator contract proxy-able * chore: simplify initializer function name * feat: add function to retrieve guarded accounts * fix: improve recovery validator logic * feat: allow paymaster calls to GuardianRecoveryValidator * feat: fix guardian recovery validator compilation * fix: add compiler version and remove unwanted comments * fix: bugs and jsdoc format to match rest of package * fix: test that included guardian contract * feat: add passkey to account relation * feat: prevent account overlap * feat: improve registered accounts logic * fix: tests * fix: unknown accounts * fix: discard recovery bug * fix: move account verifications * feat: add guardian added time to guardian information * fix: deployment * fix: address to account id is not empty when initiating recovery * fix: remove double save on guardedAccounts * Fix/paymaster-recovery-validator (#291) * fix: add missing functions from recovery validator to paymaster * feat: add guardian not self check --------- Co-authored-by: calvo.generico <[email protected]> Co-authored-by: Lukasz Romanowski <[email protected]> Co-authored-by: Agustin Aon <[email protected]>
* Add getOidcKeyRegistryContract * Add 'helloworld' test * Test should set one key * Test should revert when a non-owner tries to set a key * Test should correctly implement circular key storage * Update test/OidcKeyRegistryTest.ts * Add Oidc to dictionary
* Add OidcValidator * Update install and uninstall * Add addValidationKey * Add OidcValidator.validateTransaction * Add pkop to dictionary * Remove OidcValidatorTest
calvogenerico
force-pushed
the
feat/oidc-account-recovery
branch
from
c7dab6d to
ca9fa35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context