feat: update hook interface with tests #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpb8010
added
documentation
Removes the need for an extra bool flag. Still broken on some tests
Still not sure why some fail
|
Do we plan on merging some of these tests with the current ones or just discard the PR? @cpb8010 |
|
I would like to revisit this eventually with Lev since it has some breaking changes from his tests. The goal with this was to better support hooks that can act as both executor, validation, and as a validation module without complicating the install and remove process too much (using ERC165 instead of a flag) I don't know how important this is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: still failing some tests
Description
Create sample hooks to test
Create tests to cover hook manager interface
Show combined hook format
Additional context
So because hooks are global and unskippable it's pretty trivial to brick an account with a bad hook (even by accident).
Would love for some safety protections here in the future (like with a trusted module registry).