Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkey Account Test #254

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Passkey Account Test #254

merged 2 commits into from
Jan 13, 2025

Conversation

cpb8010
Copy link
Contributor

@cpb8010 cpb8010 commented Jan 13, 2025

Description

More transaction flow test to show integrated usage

Additional context

Can now compare account signing costs from tests

More transaction flow test to show integrated usage

Big part is the gas estimation: 300895 for passkey validation
Also type the hash correctly, since again the ethers type signature is
confused with the smart account class
@cpb8010 cpb8010 added the enhancement New feature or request label Jan 13, 2025
@cpb8010 cpb8010 requested a review from ly0va January 13, 2025 09:03
@cpb8010 cpb8010 self-assigned this Jan 13, 2025
@cpb8010 cpb8010 changed the title feat: add another test setup Passkey Account Test Jan 13, 2025
Copy link
Member

@ly0va ly0va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ly0va ly0va merged commit 140ec84 into main Jan 13, 2025
3 checks passed
@ly0va ly0va deleted the passkey-interface-coverage branch January 13, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants