feat: allow approval based paymasters #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpb8010
approved these changes
Jan 13, 2025
| @@ -93,7 +93,6 @@ contract SessionKeyValidator is IModuleValidator { | |||
| interfaceId == type(IModule).interfaceId; | |||
| } | |||
|
|
|||
| // TODO: make the session owner able revoke its own key, in case it was leaked, to prevent further misuse? | |||
There was a problem hiding this comment.
Are we not implementing this?
There was a problem hiding this comment.
Do you think we should? I think it's a feature that is very unlikely to be used, but adds complexity
There was a problem hiding this comment.
It is a nice to have. However, it is true that a key compromise will already have a much larger impact than the session itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow approval-based paymaster, while performing the necessary check that the used token is allowed in the session spec.