Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor issues #247

Merged
merged 4 commits into from
Jan 8, 2025
Merged

fix: minor issues #247

merged 4 commits into from
Jan 8, 2025

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Jan 8, 2025 •
edited
Loading

Description

  • make periods not overlap
  • add doc comment
  • remove FeePaid event
  • gas optimizations

MexicanAce
MexicanAce approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ly0va ly0va merged commit a3741e9 into main Jan 8, 2025
3 checks passed
@ly0va ly0va deleted the lyova-minor-issues branch January 8, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ly0va @MexicanAce