chore: change how validation is returned #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assumes success if the signature check reaches the end, but can also return early if the signature isn't a modular one. Also remove an unused param for a warning
cpb8010
force-pushed
the
inconsistent-validation
branch
from
2d80e4f to
3c17d81
Compare
|
Which issue does this address? The code looks identical, just uses an if statement instead of the ternary operator |
|
https://defender.openzeppelin.com/#/audit/9202b68f-3633-48de-bf0b-5b9a4855c944/issues/N-14 I didn't totally agree with this, but it's possible I'm misunderstanding the feedback there. |
ly0va
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This assumes success if the signature check reaches the end, but can
also return early if the signature isn't a modular one.
Also remove an unused param for a warning
Additional context
Audit feedback