JSON Parser Test Suite #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The truffle tests were pretty minimal, but good to keep in sync since this isn't a published package we're importing. https://github.com/chrisdotn/jsmnSol/tree/master/test
Since the existing test suite didn't catch any of the reported problems with the JSON parsing, adding another larger suite that's used to compare popular JSON parsers should! Obviously because this is so large it can be trimmed, but the hope is to find overlap between the feedback and the test-cases here.
This action is broken again, hopefully the latest works!
Tests connect to the files
Skipping all the json format tests for now, These are helpful if we want a fully compliant parser, but aren't helpful in parsing the client data JSON.
It doesn't return an error, because it doesn't actually record key values
it looks like this is fixed now
MexicanAce
reviewed
Jan 6, 2025
MexicanAce
reviewed
Jan 6, 2025
Co-authored-by: Nicolas Villanueva <[email protected]>
Co-authored-by: Nicolas Villanueva <[email protected]>
Co-authored-by: Nicolas Villanueva <[email protected]>
Covers existing functionality
Cleanup conflicts
ly0va
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding test suite to json parsing library.
Additional context
While the client data JSON isn't expected to field the broad range of formats, it can be helpful to know what's generlaly missing.