Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert address benchmark changes made in PR #51 #57

Merged

Conversation

jrchatruc
Copy link
Contributor

@jrchatruc jrchatruc commented Aug 29, 2024

What ❔

Along with this, this PR fixes changes made to addresses in the interpreter benchmark because of incorrect nonce calculations by reverting this PR.

This PR also changes the expected values on the salted_create vyper ethereum tests because on the corresponding era-compiler-tester PR the contracts submodule was updated to point to the new evm equivalence branch (evm-equivalence-yul-new), which brought a lot of new dev changes including this change to the _nonSystemDeployOnAddress function of the ContractDeployer, where this require statement was changed to this.

The test expected the old Code hash is non-zero as the revert reason; the change to the test.json updates it to be the new HashIsNonZero(codeHash).

Why ❔

Checklist

  • PR title corresponds to the body of PR.
  • Documentation comments have been added / updated.

@hedgar2017 hedgar2017 changed the title Revert address benchmark changes made in PR #51 fix: revert address benchmark changes made in PR #51 Aug 30, 2024
@hedgar2017 hedgar2017 merged commit b45db8f into matter-labs:main Sep 12, 2024
1 check passed
@jrchatruc jrchatruc deleted the revert-pr-51-address-benchmarks branch September 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants