fix: revert address benchmark changes made in PR #51 #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Along with this, this PR fixes changes made to addresses in the interpreter benchmark because of incorrect nonce calculations by reverting this PR.
This PR also changes the expected values on the
salted_create
vyper ethereum tests because on the correspondingera-compiler-tester
PR thecontracts
submodule was updated to point to the new evm equivalence branch (evm-equivalence-yul-new
), which brought a lot of new dev changes including this change to the_nonSystemDeployOnAddress
function of theContractDeployer
, where this require statement was changed to this.The test expected the old
Code hash is non-zero
as the revert reason; the change to thetest.json
updates it to be the newHashIsNonZero(codeHash)
.Why ❔
Checklist