Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests triggered by incorrect inlining of meta intrinsic #14

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

sayon
Copy link
Contributor

@sayon sayon commented Jan 25, 2024

What ❔

There were optimizer issues w.r.t. optimizing/memoization of meta instructions.

Why ❔

This testset checks our fix for the optimizer.

Checklist

  • PR title corresponds to the body of PR.
  • Documentation comments have been added / updated.

@sayon
Copy link
Contributor Author

sayon commented Jan 25, 2024

Is it alright to document tests in the comments or should I put some more information elsewhere?

@hedgar2017
Copy link
Collaborator

Is it alright to document tests in the comments or should I put some more information elsewhere?

That's great, but now please create a compiler-tester branch referencing this submodule so the CI gets run.

@sayon sayon force-pushed the iz-intrinsic-meta branch from 8e9da74 to 511bd93 Compare January 30, 2024 19:48
@hedgar2017
Copy link
Collaborator

Hey @sayon, please don't forget filling out What/Why in the PR body!

@hedgar2017 hedgar2017 merged commit 9a8c6d9 into main Jan 31, 2024
1 check passed
@hedgar2017 hedgar2017 deleted the iz-intrinsic-meta branch January 31, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants