Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: support custom LLVM branch in sanitizers #89

Merged
merged 1 commit into from
Aug 23, 2024
Merged

ci: support custom LLVM branch in sanitizers #89

merged 1 commit into from
Aug 23, 2024

Conversation

antonbaliasnikov
Copy link
Contributor

What ❔

Add the capability to choose the LLVM branch when running with sanitizers.

Why ❔

To allow testing different LLVM branches without the need to create a branch and update LLVM.lock manually.

Test

Tested manually through actions:

  1. Run with a custom branch
  2. Run with a default '' empty value

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

@antonbaliasnikov antonbaliasnikov marked this pull request as ready for review August 23, 2024 08:36
PavelKopyl
PavelKopyl approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@PavelKopyl PavelKopyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@antonbaliasnikov antonbaliasnikov merged commit 19afcee into main Aug 23, 2024
0 of 3 checks passed
@antonbaliasnikov antonbaliasnikov deleted the aba-support-llvm-branch-sanitizers branch August 23, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelKopyl PavelKopyl PavelKopyl approved these changes

@hedgar2017 hedgar2017 hedgar2017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonbaliasnikov @PavelKopyl @hedgar2017