-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LNT report serialization updates #136
Merged
Merged
+74
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbaliasnikov
force-pushed
the
aba-lnt-support
branch
5 times, most recently
from
January 28, 2025 17:33
a22f41a
to
0512646
Compare
antonbaliasnikov
changed the title
feat: initial lnt support in ci
fix: lnt reports serialization updates
Jan 28, 2025
antonbaliasnikov
requested review from
hedgar2017 and
sayon
and removed request for
hedgar2017
January 28, 2025 17:34
sayon
requested changes
Jan 28, 2025
benchmark_analyzer/src/output/format/json/lnt/benchmark/run_description.rs
Outdated
Show resolved
Hide resolved
hedgar2017
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits!
benchmark_analyzer/src/model/benchmark/test/codegen/versioned/executable/run/mod.rs
Outdated
Show resolved
Hide resolved
hedgar2017
approved these changes
Jan 29, 2025
|
|
hedgar2017
changed the title
fix: lnt reports serialization updates
fix: LNT report serialization updates
Jan 30, 2025
hedgar2017
force-pushed
the
aba-lnt-support
branch
from
January 30, 2025 18:34
abf27fb
to
caa864f
Compare
hedgar2017
approved these changes
Jan 30, 2025
sayon
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Serialization and LNT report fixes for proper reports uploading to the LNT server.
Checklist
cargo fmt
and checked withcargo clippy
.