Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LNT support and comparison of custom benchmarking groups #130

Merged
merged 14 commits into from
Jan 6, 2025
Merged

feat: LNT support and comparison of custom benchmarking groups #130

merged 14 commits into from
Jan 6, 2025

Conversation

sayon
Copy link
Contributor

@sayon sayon commented Jan 3, 2025

What ❔

  • Support generating LNT-compatible JSON files
  • Support selecting benchmark groups to compare measurements in them

Why ❔

  • Advances towards LNT integration
  • Allows comparing code generation in different frontends

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

@sayon sayon requested a review from antonbaliasnikov January 3, 2025 20:15
@sayon sayon force-pushed the iz-better-benchmark-analyzer-groups branch from b6a752a to 6bd3030 Compare January 4, 2025 11:24
@sayon sayon force-pushed the iz-better-benchmark-analyzer-groups branch from 6bd3030 to 47f6f63 Compare January 5, 2025 13:43
@sayon
Copy link
Contributor Author

sayon commented Jan 5, 2025

The tests won't pass because the internal format for benchmark-analyzer has changed, therefore benchmark analyzer can not read the file eravm-reference.json produced by the old version of compiler-tester.

@hedgar2017
Copy link
Collaborator

The tests won't pass because the internal format for benchmark-analyzer has changed, therefore benchmark analyzer can not read the file eravm-reference.json produced by the old version of compiler-tester.

Oke! The candidate is enough here. I'll review shortly.

@hedgar2017 hedgar2017 requested review from a team and removed request for antonbaliasnikov January 6, 2025 09:57
hedgar2017
hedgar2017 requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@hedgar2017 hedgar2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropped a couple of nits. Otherwise LGTM if everything works.

Thank you very much sir for this great contribution!

README.md Outdated Show resolved Hide resolved
benchmark_analyzer/Cargo.toml Outdated Show resolved Hide resolved
benchmark_analyzer/src/analysis/evm_interpreter/mod.rs Show resolved Hide resolved
benchmark_analyzer/src/model/benchmark/test/codegen/versioned/executable/run/mod.rs Outdated Show resolved Hide resolved
benchmark_analyzer/src/model/context/mod.rs Outdated Show resolved Hide resolved
compiler_tester/Cargo.toml Outdated Show resolved Hide resolved
compiler_tester/src/compiler_tester/main.rs Show resolved Hide resolved
@hedgar2017 hedgar2017 enabled auto-merge (squash) January 6, 2025 14:45
@hedgar2017
Copy link
Collaborator

Please run cargo fmt --all through; that check is mandatory.

@hedgar2017 hedgar2017 merged commit a98fc01 into main Jan 6, 2025
11 of 12 checks passed
@hedgar2017 hedgar2017 deleted the iz-better-benchmark-analyzer-groups branch January 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonbaliasnikov antonbaliasnikov antonbaliasnikov left review comments

@hedgar2017 hedgar2017 hedgar2017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayon @hedgar2017 @antonbaliasnikov