-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support CSV output #119
Conversation
|
61c980a
to
2b79711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an amazing piece of work, thank you!
I've left a few nits.
Have you tested all major use cases manually? I'd like to produce a benchmark of our LLVM EVM BE against solc. Is it able to compare reports such as Y+M3B3
with Y+
?
compiler_tester/src/compiler_tester/arguments/benchmark_format.rs
Outdated
Show resolved
Hide resolved
Fixed the comments! Let's merge when we can to minimize future conflicts. LNT will be able to compare Y+M3B3 and Y+. But for now we can already do that using the CSV output, which is uniform regardless of the target. For example, if I execute the following:
then I can import both files to a spreadsheet for example to gdocs and do basic statistics there. Once we plug in another backend to generate JSON for LNT, it can be automated. |
What ❔
Why ❔
Checklist
cargo fmt
and checked withcargo clippy
.