[EVM][LLD] relocate: remove wrong numeric limit

matter-labs · Jan 28, 2025 · 8a28c66 · 8a28c66
1 parent a83a0fd
commit 8a28c66
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lld/ELF/Arch/EVM.cpp b/lld/ELF/Arch/EVM.cpp
@@ -60,9 +60,7 @@ RelExpr EVM::getRelExpr(RelType type, const Symbol &s,
 void EVM::relocate(uint8_t *loc, const Relocation &rel, uint64_t val) const {
   switch (rel.type) {
   case R_EVM_DATA: {
-    if (val > std::numeric_limits<uint32_t>::max())
-      llvm_unreachable("R_EVM_DATA: to big relocation value");
-    write32be(loc, val);
+    write32be(loc, static_cast<uint32_t>(val));
     break;
   }
   default:

diff --git a/lld/unittests/EVM/LLDTest.cpp b/lld/unittests/EVM/LLDTest.cpp
@@ -136,7 +136,8 @@ define i256 @foo() {                                              \n\
   const char *LinkerSymbol[2] = {"library_id", "library_id2"};
   const char LinkerSymbolVal[2][20] = {
       {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
-      {7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7}};
+      {'\x9f', 0x1E, '\xBB', '\xF1', 7, 7, 7, 7, 7, 7,
+       7,      7,    7,      7,      7, 7, 7, 7, 7, 7}};
   StringRef SymVal1(LinkerSymbolVal[0], 20);
   StringRef SymVal2(LinkerSymbolVal[1], 20);